Generally a Code Review is not include in the Unit Test Process.
The Unit Test is done by the QA staff or the end users.
A code review is the IT Developement staff looking at the actual source code.
Register Hereor login if you are already a member
I don't have a list (that was just being discussed for implementation at my previous employment at the time of my departure).
However, I would think you would want to look at how the code compares to the departmental standards.
Use of current vs obsolete opcodes. (I saw a recent post with CABxx opcodes-who does that anymore?)
Efficient use of code. I have encountered code that used multiple lines of code to do what could be performed a single line of code.
Is code that should be in a called procedure used in the code instead of the procedure?
Variable names clear (i.e. we are not using variable A1 for the Customer Number)
Internal documentation, sufficient? No useless/redundant documentation (i.e. the code is self explanatory enough?)
Screens and reports well designed? Do they make sense?
Best techniques used? Could an SQL statement be a better technique in part of the code?
Keep the code modern (I have a predecessor that used RPGIV specifications, but the code looks very much like RPG II (conditioning indicators, GOTO, etc.)
@TheRealRavin I will agree, that it has to work correctly first before making it pretty. By time it gets to code review, I think that should be resolved.
One thing I would add to my list, Is the code readable? I have looked at code and wondered what it is supposed to be doing. Favorite line of code I ever encountered: *off doueq *on
I recall one job interview, I was asked to read some code and tell the interviewer what the code was doing. I read the documentation and said "it has something to do with payroll" and was asked "how did you get that so fast", to which I replied "I read the documentation". I never heard back from them after the interview. I thought we did documentation to make it easier for someone coming after me (or even me in 6 months).
Punch cards, what are they. Just kidding. I had to write one program on punch cards in a COBOL class "for the experience". I came across a website today that is a tutorial (last updated in 2015) for RPG, not even RPGII. I had never seen old style RPG previously, so that was interesting to look at (thankfully, never have to code in). I did do a little with RPGII (not much), really starting with RPGIII and progressing to RPG free.
I have used variables like a, b, c for counters, particularly in RPGIII with arrays and tables since there really wasn't much space for larger variables in those situations. But, I always documented the variable name and use in the program header.