Most likely what’s happening is you ran the macro with the form closed. The form has to be open for access to read Forms!Client!ID. If the macro runs with the form closed it will prompt you for the parameter. To make sure the form is always open when the macro is run you may to put a Docmd openform at the beginning.
If that wasn’t the case then access is acting funky and you may have to try a different way to filter the data. (Build a query with [Forms]![Client]![ID} in the equals part and link your receipts forms to the query instead of to the Clients table)