Comments on: batching qsh sftp fails when using a variable for script

By: The most-watched IT questions: April 12, 2012 - ITKE Community Blog

The most-watched IT questions: April 12, 2012 - ITKE Community Blog — Mon, 16 Apr 2012 03:03:52 +0000

[...] 4. Several community members come together as they try to solve BDLmichael’s problem solving a iSeries command error. [...]

By: tomliotta

tomliotta — Fri, 30 Mar 2012 23:42:18 +0000

There is more code, but…

Ah. Not exactly out of context, just misinterpreted by me. Now I see the alternative interpretation. In that case, there’s no need for my related comment.

Tom

By: wpoulin

wpoulin — Fri, 30 Mar 2012 14:50:32 +0000

Tom,

You took my statement out of context. My full statement was;

There is more code, but I didn’t think it related to executing QSH in batch and with a variable.

Thank You,
Bill Poulin

By: tomliotta

tomliotta — Fri, 30 Mar 2012 00:23:36 +0000

This command expects a null terminated parameter

It’s already known that a null-terminator is not needed. The QSH command works fine without one as demonstrated by the OP’s working example. The issue is in the difference between using a literal for the QSH command parameter and a variable. Because QSH is a system command, it has no need for a null-terminator.

Tom

By: mmanley

mmanley — Thu, 29 Mar 2012 14:38:05 +0000

You probably need to trim the string, and append a X’00′ to the end. This command expects a null terminated parameter

By: tomliotta

tomliotta — Wed, 28 Mar 2012 22:37:12 +0000

…I didn’t think it related to executing QSH in batch and with a variable.

It’s definitely related when extra quotes are added that shouldn’t be there.

But the idea of using a literal or a variable is sound. Just don’t put quotes in the variable that aren’t present in the literal.

Tom

By: wpoulin

wpoulin — Wed, 28 Mar 2012 15:02:52 +0000

It should be ZSFTP is the command.

Bill

By: wpoulin

wpoulin — Wed, 28 Mar 2012 15:01:35 +0000

This can work, I have a similar job that runs thru the Job Scheduler, Here is a snippet of the code, maybe an example will help, ZFTP is a command that executes a CL by the same name; ZSFTP HOST(***.nh.gov) SCRIPT('/tmp/lowmo') + USER('******') PGM PARM(&HOST &SCRIPT &USER) DCL VAR(&HOST) TYPE(*CHAR) LEN(15) DCL VAR(&SCRIPT) TYPE(*CHAR) LEN(15) DCL VAR(&USER) TYPE(*CHAR) LEN(15) DCL VAR(&CMD) TYPE(*CHAR) LEN(500) ADDENVVAR ENVVAR(SFTP_USER) VALUE(&USER) REPLACE(*YES) ADDENVVAR ENVVAR(SFTP_HOST) VALUE(&HOST) REPLACE(*YES) CHGVAR VAR(&CMD) + VALUE('PATH=$PATH:/QOpenSys/usr/bin && + sftp -b' *BCAT &SCRIPT *TCAT '.sftp + $SFTP_USER@$SFTP_HOST 22') QSH CMD(&CMD) Again this is run in batch thru the Job Scheduler. There is more code, but I didn't think it related to executing QSH in batch and with a variable. Hope this helps, Bill Poulin

By: tomliotta

tomliotta — Tue, 27 Mar 2012 20:08:08 +0000

...using three single quotes... Why would you put three quotes there? I've never tested it, but what happens when you put quotes around a command on a QSH command line? If I try this:

===> 'ls /home/toml'

...to list my /home directory in a QSH session, I get this error:

qsh: 001-0014 Command ls /home/toml not found.

QSH thinks that the entire quoted string is the name of the command. Your &CMDSHL value should probably only have single quotes. Tom

By: bdlmichael

bdlmichael — Tue, 27 Mar 2012 15:55:19 +0000

Hi again - the CL command is CHGVAR &CMDSHL ('''/QOpenSys/usr/bin/sftp -v -b + /home/WIRM123/sftpcmd.txt wirm123@sftp2.123''') using three single quotes the string from the debug session is as below ( 200 type character string ) '/QOpenSys/usr/bin/sftp -v -b /home/WIRM123/sftpcmd.txt wirm123@sftp2.123' the CL code to execute ( and fails) is SBMJOB CMD(QSH CMD( &CMDSHL )) JOB(SSHJOB) USER(WIRM123) the sftpcmd.txt is is a simple text file cd Share/5501/test/5501updt ls put MGG1.TXT MGG1.TXT ls exit this all works when I make the hardcoded call as below SBMJOB CMD(QSH CMD('/QOpenSys/usr/bin/sftp -v -b + /home/WIRM123/sftpcmd.txt + wirm123@sftp2.123')) + JOB(SSHJOB) USER(WIRM5501) but I want to be able to provide different directories and such as this is in a generic CL intersting problem - but I've reached the end of my skills as far as what to be able to test.